Passages app updates #270
Merged
Passages app updates #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
linearcombination
commented
Jul 2, 2025
linearcombination
commented
- Passages page functionality requested by PO
- Configurable asset acquisition method: download (via curl) or clone (via git)
- Use of user agent string value and X-Requested-With value to attempt to increase Cloudflare throughput
Can choose to download and unzip or to clone via configuration setting
This fixes a bug whereby if USFM was chosen only USFM resource names would show in the first page document title. Now it includes a description of all the resources chosen in the document title page. Logic is simplified too.
Updates were made to github publish which requires this change to build locally.
By request of product owner
To accomplish better performance
By request of PO
More to be done, as it was recommended by dev-ops, but does not seem to work as advertised. More to come.
To avoid potential exceptions due to missing file
Remove html2docx which we don't use
Some assets are not found in zip form correctly at this time.
PurpleGuitar
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.