Skip to content

Conversation

@linearcombination
Copy link
Contributor

@linearcombination linearcombination commented Jul 16, 2025

  • Fix issue with ordering of books in document title and document content for book then lang assembly strategy, i.e., interleave by chapter.
  • Prior to this PR, visual section separators (horizontal line) were always added, but there were some glitches where the horizontal line would only show for one half the width of the page at the end of two colum layout sections. I decided it would be better to make adding visual section separators a user choice on the final submission page, i.e., the settings page, of the document generation process (located under "Optional Settings") while also eliminating this glitch. This led to the the next item which was the way to handle docx document generation in a nicer way:
  • Restructure docx assembly so that document parts are accumulated but not actually created until the end when the parts are finally composed in a centralized location. This helps code deduplication and follows a lazy instantiation pattern that is easier to reason about and less imperative.
  • Add tests for content ordering by bible book order.
  • Some additional code deduplication for document_generator.generate_document and document_generator.generate_docx_document by sharing common code through a refactor.

Centralize imperative logic rather than having it strewn about.
This impacts interleaving, but also the title strings at the top of
the generated document.
Ground work for making the use of hr elements between sections a
user-selectable option in the UI. Also important since our
DocumentPart(s) interpreter now handles all hr element insertion for
docx.
Missed a couple spots where this change was previously made.
Use analogous document parts being interpreted to a whole as we do for
docx generation. A nice side effect is that we get easier testing of
content, e.g., ordering, as well.
@PurpleGuitar PurpleGuitar merged commit d05661a into doc-dev.walink.org Jul 16, 2025
38 of 43 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in DOC Project Management Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants