Merge data API data with DOC only data #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For certain languages, e.g., id, there is data approved to show on DOC, e.g., ayt, that is not provided by data API. I noticed a bug where sometimes there could be two Indonesian (id) entries on the language page because the data API was returning id data slightly different than what DOC provided (as data returned by data API evolves over time). This commit makes it so that any data for a particular language, resource combo will be preferred over what DOC was merging into the data, that way if the data changes over time, data API wins.
PurpleGuitar
approved these changes
Aug 29, 2025
Contributor
PurpleGuitar
left a comment
PurpleGuitar
left a comment
There was a problem hiding this comment.
Looks good. Thanks Lang!
github-project-automation
bot
moved this from In progress
to Done
in DOC Project Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain languages, e.g., id, there is data approved to show on DOC, e.g., ayt, that is not provided by data API. I noticed a bug where sometimes there could be two Indonesian (id) entries on the language page because the data API was returning id data slightly different than what DOC provided (as data returned by data API evolves over time). This commit makes it so that any data from data API for a particular language, resource combo will be preferred over what DOC was merging into the data, that way if the data changes over time, data API wins.