Passages ot rg and conditional stet passages #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requested DOC feature
Make it clear that when the Gateway tab is selected, the search field searches gateway languages and when the Heart tab is selected, the search field searches heart languages. Before this commit it only said search languages which could lead one to believe you are searching across all languages.
Make the code more extensible and easier to understand.
By request of TS
It provides no needed value and is just another phrase that would need to be localized.
Russian (ru) exhibited some USFM with this USFM structural mistake.
This is the cache for file artifacts which include graphql query results, resources.json, git repos, and generated document files. 30 minutes is long enough to materially impact running of the test suite to make it considerably faster and short enough to allow new updates to data to become available without too long of a wait.
…t-05-19-2025 Update to doc and stet 05 19 2025
Graphql lookups are generally quick and hopefully stability has improved. Let's simplify the code and remove caching of graphql data.
Disable graphql cache
Put checkbox to select NT Survey Reviewer's Guide Passages on its own row.
Prior refactor apparently broke this.
Only show STET source languages that provide 4th column (boldings) in their input document
PurpleGuitar
approved these changes
Sep 25, 2025
| # is True, then the chapter label will be localized to the language(s) | ||
| # requested. | ||
| use_chapter_labels: bool = False | ||
| # We have two PDF processors that we can use: Weasyprint and Princexml. |
Contributor
There was a problem hiding this comment.
Thanks for providing the option to choose between the PDF processors. Is there a way to choose them at runtime? (I'm guessing not -- this looks like an deployment-time decision.)
Perhaps we could generate some Prince PDFs vs Weasy PDFs and let TS review them. They could then decide if they're willing to live with the logo in return for the superior layout.
Contributor
Author
|
From: Craig Oliver ***@***.***>
Subject: Re: [WycliffeAssociates/DOC] Passages ot rg and conditional stet passages (PR #279)
Date: Thu, 25 Sep 2025 11:43:47 -0700
Yes, they are choose-able in the UI on the settings page. If one chooses PDF then a switch appears allowing to choose Princexml as an option, otherwise it defaults to weasyprint. If you have time you might want to try it at our dev server location. Thanks for the feedback!
… @PurpleGuitar approved this pull request.
> @@ -201,6 +201,26 @@ class DocumentRequest(BaseModel):
# is True, then the chapter label will be localized to the language(s)
# requested.
use_chapter_labels: bool = False
+ # We have two PDF processors that we can use: Weasyprint and Princexml.
Thanks for providing the option to choose between the PDF processors. Is there a way to choose them at runtime? (I'm guessing not -- this looks like an deployment-time decision.)
Perhaps we could generate some Prince PDFs vs Weasy PDFs and let TS review them. They could then decide if they're willing to live with the logo in return for the superior layout.
--
Reply to this email directly or view it on GitHub:
#279 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
linearcombination
merged commit f59b61d
into
doc.bibleineverylanguage.org
15 checks passed
github-project-automation
bot
moved this from In progress
to Done
in DOC Project Management
linearcombination
temporarily deployed
to
doc-dev.walink.org
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.