Passages fixes and new features #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation words are scoped by language and not by book. This could have been changed a long time ago, but it was doing no harm. Just cleaning up the design a bit.
Make checkboxes for each passage group type only be visible if the language chosen has at least one of the members of that group. Only show select all for OT rg if all four rg groups (rg1, rg2, rg3, rg4) are present. Only add those passages from each group type which actually exist for the language chosen. Add e2e tests to test this.
PurpleGuitar
approved these changes
Nov 26, 2025
| tq_book | ||
| for tq_book in tq_books | ||
| if tq_book.book_code == tq_book.book_code | ||
| if tq_book.book_code == book_code |
github-project-automation
bot
moved this from In progress
to Done
in DOC Project Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make checkboxes for each passage group type only be visible if the
language chosen has at least one of the members of that group. Only
show select all for OT rg if all four rg groups (rg1, rg2, rg3, rg4)
are present. Only add those passages from each group type which
actually exist for the language chosen. Add e2e tests to test this.