Skip to content

Return WMarker Term from preprocess #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsarabia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return WMarker Term from preprocess #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion USFMToolsSharp/Models/Markers/WMarker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public override string PreProcess(string input)

}

return string.Empty;
Copy link
Member

@rbnswartz rbnswartz Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also need to add TextBlock to allowed markers in order for this to work as expected, otherwise we have a WMarker with the word set and then a text block following it, we would want this to contain that text block. Also if we go down this route I don't think we want to include an attribute for term here, there are others that we do this with we would want to handle those also.

return Term;
}

}
Expand Down