Make IgnoreABI configurable through config files #1473
+201
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is patch 1/4 of a series that provides a convenient way to specify IgnoreABI on a per-driver/per-module basis through config files. Two Bool variables LoaderIgnoreABI (specific) and LoaderIgnoreAllABI (server-wide) together with helper functions are used to control loader and modules behavior. More verbosity added. Signed-off-by: Oleh Nykyforchyn <[email protected]>
It is patch 2/4 of a series that provides a convenient way to specify IgnoreABI on a per-driver/per-module basis through config files. A list of such modules is specified in OutputClass, which is applied only if certain conditions are met e.g., nvidia-drm driver is loaded. Signed-off-by: Oleh Nykyforchyn <[email protected]>
It is patch 3/4 of a series that provides a convenient way to specify IgnoreABI on a per-driver/per-module basis through config files. This patch adds an "Option IgnoreABI" line to the file /usr/share/X11/xorg.conf.d/10-nvidia.conf with an OutputClass, which makes the loader ignore ABI for the drivers and modules for all devices managed by the nvidia-drm kernel driver. Signed-off-by: Oleh Nykyforchyn <[email protected]>
It is patch 4/4 of a series that provides a convenient way to specify IgnoreABI on a per-driver/per-module basis through config files. This patch updates the man page. Signed-off-by: Oleh Nykyforchyn <[email protected]>
Contributor
|
@ONykyf Is this desired for anything other than Nvidia? |
Contributor
Author
For now - no. I rather leave this as a room for future decisions if ignoring ABI will (hypothetically) NOT be necessary for future NVidia releases. |
metux
reviewed
Dec 3, 2025
hw/xfree86/common/xf86platformBus.c
Outdated
| if (cl->modules) { | ||
| LogMessageVerb(X_CONFIG, 1, " and for modules \"%s\" as well\n", | ||
| cl->modules); | ||
| XNFasprintf(©, "%s", cl->modules); |
Contributor
There was a problem hiding this comment.
can we please use asprintf() here ?
Contributor
Author
There was a problem hiding this comment.
can we please use asprintf() here ?
OK, I'll do this.
Contributor
Author
There was a problem hiding this comment.
@metux
So XNFasprintf / XNFvasprintf will be eliminated completely in the code?
Contributor
Author
There was a problem hiding this comment.
@metux I have replaced all previously introduced XNFasprintfs with asprintfs.
This patch replaces all occurences of XNFasprintf() in xf86platformBus.c and OutputClass.c with asprintf(). Signed-off-by: Oleh Nykyforchyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series gives a user/maintainer the power to decide whether to ignore ABI version for any driver/module depending on the loaded DRM kernel drivers (with NVidia legacy drivers in mind, and a configuration file for this is included), and this policy is controlled via
/usr/share/X11/xorg.conf.d/*.conffiles.