Skip to content

Conversation

@shenyangshi
Copy link

A small change that makes the automatic differentiation between midway3 and midway2.

@shenyangshi shenyangshi requested a review from dachengx March 22, 2024 15:41
@coveralls
Copy link

coveralls commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8884113640

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.979%

Totals Coverage Status
Change from base Build 8848981890: 0.0%
Covered Lines: 1548
Relevant Lines: 1683

💛 - Coveralls

@shenyangshi shenyangshi requested a review from hammannr March 22, 2024 16:35
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should:

  1. add a condition for midway2 and midway3
  2. warn the user if the hostname is not understandable and assign nothing

@shenyangshi shenyangshi requested a review from dachengx April 29, 2024 19:05
@shenyangshi
Copy link
Author

excluded_nodes as null is added as default for midway3, as without an explicit excluded_nodes, midway3 job submission will yield error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants