Skip to content

feat: Support single asset vault #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 27, 2025

Conversation

PeterChen13579
Copy link
Collaborator

fixes #1921

@PeterChen13579 PeterChen13579 marked this pull request as draft March 27, 2025 22:25
@PeterChen13579 PeterChen13579 added this to the 2.5 milestone Mar 31, 2025
@PeterChen13579 PeterChen13579 marked this pull request as ready for review March 31, 2025 19:39
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 79.80769% with 21 lines in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (d97f19b) to head (99803fb).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/handlers/VaultInfo.cpp 85.13% 6 Missing and 5 partials ⚠️
src/rpc/handlers/VaultInfo.hpp 44.44% 0 Missing and 5 partials ⚠️
src/rpc/handlers/LedgerEntry.hpp 60.00% 0 Missing and 4 partials ⚠️
src/rpc/handlers/LedgerEntry.cpp 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1979      +/-   ##
===========================================
+ Coverage    73.17%   73.22%   +0.04%     
===========================================
  Files          370      372       +2     
  Lines        15145    15246     +101     
  Branches      7661     7715      +54     
===========================================
+ Hits         11083    11164      +81     
- Misses        1926     1931       +5     
- Partials      2136     2151      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PeterChen13579 PeterChen13579 force-pushed the SupportSingleAssetVault branch from e958ddd to 9ecda27 Compare May 29, 2025 20:22
@PeterChen13579 PeterChen13579 requested a review from godexsoft June 3, 2025 14:42
@kuznetsss kuznetsss requested a review from mathbunnyru June 23, 2025 15:41
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things. Overall looks good 👍

godexsoft
godexsoft previously approved these changes Jun 27, 2025
Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shows why long-living PRs are bad - unfortunately, many things were changed universally in develop and now they have to be fixed here as well

@kuznetsss kuznetsss merged commit 3712374 into XRPLF:develop Jun 27, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Single Asset Vault
4 participants