Skip to content

style: Add typos pre-commit hook #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025

Conversation

mathbunnyru
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (427ba47) to head (e902db7).
Report is 80 commits behind head on develop.

Files with missing lines Patch % Lines
src/data/BackendInterface.cpp 0.00% 1 Missing and 1 partial ⚠️
src/etl/impl/LedgerLoader.hpp 0.00% 1 Missing ⚠️
src/etlng/ETLService.hpp 0.00% 1 Missing ⚠️
src/web/impl/ErrorHandling.hpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2041      +/-   ##
===========================================
+ Coverage    72.71%   72.75%   +0.03%     
===========================================
  Files          333      355      +22     
  Lines        13525    14697    +1172     
  Branches      6881     7464     +583     
===========================================
+ Hits          9835    10693     +858     
- Misses        1785     1976     +191     
- Partials      1905     2028     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru requested review from godexsoft and kuznetsss and removed request for godexsoft April 28, 2025 10:43
godexsoft
godexsoft previously approved these changes Apr 28, 2025
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool 🚀 I'm only worried about the hashes that we need to maintain in the toml file and also, did you verify all the golang changes work? TestUnavailableMethods seems unused entirely.

@mathbunnyru
Copy link
Collaborator Author

Pretty cool 🚀 I'm only worried about the hashes that we need to maintain in the toml file and also, did you verify all the golang changes work? TestUnavailableMethods seems unused entirely.

I think it doesn't have to be used or mentioned anywhere, because it's a name of the test.
So, it runs when go test runs

@mathbunnyru mathbunnyru merged commit af0a8af into XRPLF:develop Apr 29, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants