-
Notifications
You must be signed in to change notification settings - Fork 63
test: Add build_and_test
reusable workflow
#2048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build_and_test
reusable workflow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2048 +/- ##
===========================================
+ Coverage 72.71% 72.76% +0.05%
===========================================
Files 333 355 +22
Lines 13525 14697 +1172
Branches 6881 7464 +583
===========================================
+ Hits 9835 10695 +860
- Misses 1785 1975 +190
- Partials 1905 2027 +122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Now we don't upload unit_tests bin when code coverage is enabled. That's why we build gcc Debug build for code coverage, but don't upload binaries.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction this is going 👍 I saw there is an issue with artifact names in the mac portion (https://github.com/XRPLF/clio/actions/runs/14693922110/job/41233037563). I assume this is fixed or will be fixed in another PR.
Thanks! Yes, I fixed it in another PR: #2042, merged it to develop, and updated this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Reasons:
I don't want to usesteps.conan_export_output.outputs.conan_profile
, so mac build is expected to fail on artifact download till we merge #2042