infinite loop test #6064
infinite loop test #6064
Conversation
mvadari
force-pushed
the
infinite-loop
branch
from
2227d15 to
dda7adc
Compare
mvadari
changed the base branch from
ripple/smart-escrow2
to
ripple/wamr-host-functions
mvadari
added
the
DraftRunCI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/wasmi-host-functions #6064 +/- ##
=============================================================
- Coverage 79.1% 79.1% -0.0%
=============================================================
Files 827 827
Lines 70993 70993
Branches 8304 8302 -2
=============================================================
- Hits 56133 56128 -5
- Misses 14860 14865 +5 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
changed the base branch from
ripple/wamr-host-functions
to
ripple/wasmi-host-functions
mvadari
force-pushed
the
infinite-loop
branch
from
dda7adc to
182e542
Compare
mvadari
force-pushed
the
infinite-loop
branch
from
182e542 to
ea4d668
Compare
mvadari
removed
the
DraftRunCI
There was a problem hiding this comment.
Pull request overview
This PR adds a test to verify that WebAssembly infinite loops are properly detected and handled. The test expects infinite loop execution to be caught and return a tecFAILED_PROCESSING error efficiently.
- Adds
testInfiniteLoop()test function with embedded WASM bytecode containing an infinite loop - Integrates the new test into the test suite execution
- Tests that infinite loops fail appropriately with
tecFAILED_PROCESSINGerror code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
| return x; | ||
| } | ||
| */ | ||
| static std::string const infiniteWasmHex = |
There was a problem hiding this comment.
should be in fixtures.cpp
There was a problem hiding this comment.
I left it here because it's only used once. Would you prefer it still go into fixtures?
| } | ||
|
|
||
| void | ||
| testInfiniteLoop() |
There was a problem hiding this comment.
It would be better to put it next to recursion too deep test. It is not so unique test to put it into dedicated function.
| using namespace test::jtx; | ||
| Env env{*this}; | ||
|
|
||
| /* |
There was a problem hiding this comment.
this should be in fixtures sources. here you can leave source file name
2 participants
High Level Overview of Change
This PR adds a simple infinite loop test. It passes in negligible time.
Note: this PR shouldn't be merged until the Wasmi changes are added to the base branch. This test has been verified locally against that branch, but CI isn't passing yet.
Context of Change
Testing
Type of Change
API Impact
N/A
Test Plan
Added a test. It passed efficiently.