-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1839 - Document ignore_default field for account_lines API method #2970
base: master
Are you sure you want to change the base?
Conversation
1ded039
to
45dc101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions about this parameter. It is my (strongly held) understanding that a trust line that is truly in its default state is automatically deleted. So this parameter must do something slightly different than that. Perhaps it omits trust lines that have where only the perspective account's settings are in the default state—and probably a zero balance as well?
Otherwise, seems fine.
docs/references/http-websocket-apis/public-api-methods/account-methods/account_lines.md
Outdated
Show resolved
Hide resolved
…-methods/account_lines.md Co-authored-by: Rome Reginelli <[email protected]>
Yeah, I think in this context, "default state" means trust lines where the perspective account has not modified the trust limit and has not applied any custom flags. I don’t think balance is considered in the filtering though. https://github.com/XRPLF/rippled/blob/develop/src/xrpld/rpc/handlers/AccountLines.cpp#L211-L234 |
Based on that I think balance is considered because it checks who owes a reserve. The account with a positive (nonzero) balance owes the reserve. |
Issue #1839
Adds missing ignore_default request parameter.