Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1839 - Document ignore_default field for account_lines API method #2970

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maria-robobug
Copy link
Contributor

@maria-robobug maria-robobug commented Jan 30, 2025

Issue #1839

Adds missing ignore_default request parameter.

@maria-robobug maria-robobug linked an issue Jan 30, 2025 that may be closed by this pull request
@maria-robobug maria-robobug force-pushed the 1839-document-ignore_default-field branch from 1ded039 to 45dc101 Compare January 30, 2025 12:23
@maria-robobug maria-robobug marked this pull request as ready for review January 30, 2025 12:23
@maria-robobug maria-robobug requested review from mDuo13 and removed request for mDuo13 January 30, 2025 12:27
@maria-robobug maria-robobug added the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Jan 30, 2025
@maria-robobug maria-robobug requested a review from mDuo13 January 31, 2025 10:22
mDuo13
mDuo13 previously approved these changes Jan 31, 2025
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions about this parameter. It is my (strongly held) understanding that a trust line that is truly in its default state is automatically deleted. So this parameter must do something slightly different than that. Perhaps it omits trust lines that have where only the perspective account's settings are in the default state—and probably a zero balance as well?

Otherwise, seems fine.

…-methods/account_lines.md

Co-authored-by: Rome Reginelli <[email protected]>
@maria-robobug
Copy link
Contributor Author

maria-robobug commented Feb 4, 2025

Yeah, I think in this context, "default state" means trust lines where the perspective account has not modified the trust limit and has not applied any custom flags. I don’t think balance is considered in the filtering though.

https://github.com/XRPLF/rippled/blob/develop/src/xrpld/rpc/handlers/AccountLines.cpp#L211-L234

@mDuo13
Copy link
Collaborator

mDuo13 commented Feb 7, 2025

Yeah, I think in this context, "default state" means trust lines where the perspective account has not modified the trust limit and has not applied any custom flags. I don’t think balance is considered in the filtering though.

https://github.com/XRPLF/rippled/blob/develop/src/xrpld/rpc/handlers/AccountLines.cpp#L211-L234

Based on that I think balance is considered because it checks who owes a reserve. The account with a positive (nonzero) balance owes the reserve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undocumented ignore_default field in account_lines
2 participants