Improve homepage FCP/LCP performance and image loading with responsiv… #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mDuo13
requested changes
Mar 12, 2025
Comment on lines
+118
to
+123
| width="1216" | ||
| height="667" | ||
| loading="eager" | ||
| fetchPriority="high" | ||
| src={require('./static/img/home-hero.svg')} | ||
| sizes="(max-width: 539px) 400px, (max-width: 991px) 650px, 1216px" |
There was a problem hiding this comment.
Something is wrong with the new sizes—they cause the main image to be too large, so that the title and tagline are "below the fold" at a 1080p screen size. Compare:
| Current production | Preview Build |
|---|---|
 |
 |
| "The blockchain for business" is visible without scrolling | "The blockchain" is cut off |
Comment on lines
-521
to
-524
| #home-hero-graphic { | ||
| content: url("../img/lightmode/home-hero.svg"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Currently, the home hero image has two versions. The version for light mode has slightly darker colors for the "X" to improve contrast. (Compare: for dark mode vs for light mode)
I don't know if this change was intentional or accidental. If it's intentional, then you should also delete the light mode image now that it's not used.
| @@ -672,7 +668,7 @@ pre { | |||
| ##{$company} { | |||
| .biz-logo { | |||
| max-height: 40px; | |||
| content: url("../img/uses/lightmode/#{$company}.#{$type}"); | |||
| content: url("../img/uses/lightmode/#{$company}.#{$type}"); | |||
There was a problem hiding this comment.
Why are you adding whitespace to the end of these lines? That seems unnecessary and clutters the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e optimizations.
Live Site:
This branch:
