Verify credential tutorial (Python) #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mDuo13
added
the
new topic
2 tasks
mDuo13
added
the
needs japanese translation
maria-robobug
previously approved these changes
Mar 19, 2025
There was a problem hiding this comment.
LGTM, just added a few minor comments.
FYI, I encountered an issue when running the credential issuer code on my Mac (nothing to do with the code itself, just Flask and macOS issues). Basically it looks like port 5000 is already used by macOS Sequoia (and probably previous versions) for the AirPlay Receiver, if it's enabled. We should suggest that Mac users try a different port from the default Flask port if they have this enabled:
flask --app issuer_service run --port 8000 More info here:
https://stackoverflow.com/questions/72795799/how-to-solve-403-error-with-flask-in-python
verify_credential: comment out unused error Verify credential: implement commandline usage Add verify creds tutorial Verify credential: expand example usage Verify credential: clarify Python version Verify Credential: add description metadata Apply suggestions from @maria-robobug review Co-authored-by: Maria Shodunke <[email protected]> Credential Verification: Add hex example & remove old TODO
|
Applied review changes, rebased & squashed, and added links between the two Credentials tutorials. |
maria-robobug
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion tutorial to #2960 based on feedback. Demonstrates how to verify that a credential exists and is valid.
Preview link: https://xrpl-dev-portal--verify-cred.preview.redocly.app/docs/tutorials/python/compliance/verify-credential
These steps are not necessary for DepositAuth or many of other forthcoming the use cases that use Credentials as part of Permissioned Domains to grant access to things like Permissioned DEXes, MPTs, etc—because, in those cases, the ledger performs credential verification automatically. However, there are other use cases for Credentials in which you might want to verify them like this.
If you want to create additional credentials for testing with this, you can run the code from #2960.
I expect (someone) to make a separate JavaScript version with a web interface (possibly as a Dev Tool also) eventually. To make the review process easier, I did not try to include both languages in one PR.