Update internal data types in reference docs #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tequdev
reviewed
Jun 30, 2025
| @@ -27,7 +27,7 @@ _([NonFungibleTokensV1_1 amendment][]により追加されました。)_ | |||
| ## NFTokenID | |||
|
|
|||
|
|
|||
| NFTokenID, 任意, 文字列, Hash256 | |||
There was a problem hiding this comment.
If based on rippled source code, it is Uint256, but if based on server_definition, it is Hash256.
Do you mean to change it to be based on rippled source code?
There was a problem hiding this comment.
Yes, I'm going based on the source code. I do mention the values used in server_definitions.
oeggert
requested changes
Jul 4, 2025
docs/references/protocol/ledger-data/ledger-entry-types/nftokenoffer.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/transactions/types/mptokenissuancecreate.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/ledger-data/ledger-entry-types/mptoken.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/ledger-data/ledger-entry-types/mptokenissuance.md
Outdated
Show resolved
Hide resolved
- Improve consistency of amendment notices in transaction reference - Clarify availability of tokens in payment channels - Other minor fixes
mDuo13
force-pushed
the
update_tx_ref_tables
branch
from
03fc6c1 to
e45f5a0
Compare
mDuo13
added
the
needs japanese translation
mDuo13
added a commit
that referenced
this pull request
Jul 15, 2025
- Add missing common links snippet. - Fix case of `Fee` field and string type of example value. - Update internal type names per #3164
mDuo13
added a commit
that referenced
this pull request
Jul 15, 2025
- Add missing common links snippet. - Fix case of `Fee` field and string type of example value. - Update internal type names per #3164
oeggert
reviewed
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #3163 but I split it off because the diff is very large and mostly consists of uninteresting find-and-replace and whitespace changes. (This has been rebased on
masterafter merging that PR.)NFTokenMinterfield of AccountSet should be AccountID not "Blob")Delegatetransaction common field (This fixes one of the problems identified in Permission Delegation reference documentation is mixed up #3186.)TokenEscrowamendment) in some references. This fixes part of the problem identified in TokenEscrow functionality isn't tagged with the amendment that adds it #3187.