-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Clio 2.5.0 Release Notes #3189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Clio 2.5.0 Release Notes #3189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview looks good, although I have some quibbles with the categorization of some stuff. And of course, it has yesterday's date but the Clio release still isn't live today so that will need to change.
@@ -0,0 +1,258 @@ | |||
--- | |||
category: 2025 | |||
date: "2025-07-10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update with whatever the final release date becomes
|
||
### Features | ||
|
||
- Add extensions for ETLng ([#1967](https://github.com/XRPLF/clio/pull/1967)) by [@godexsoft](https://github.com/godexsoft) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of these "features" don't feel like features from an end-user standpoint. For example, "ETLng" is just a rewritten version of the internal part of Clio that loads data from the ledger. I would put that under Refactor, and try to keep the "Features" section to new things that users of Clio might want to know about.
- Add new Docker images structure, tools image ([#2185](https://github.com/XRPLF/clio/pull/2185)) by [@mathbunnyru](https://github.com/mathbunnyru) | ||
- Add ubsan build to nightly release ([#2190](https://github.com/XRPLF/clio/pull/2190)) by [@mathbunnyru](https://github.com/mathbunnyru) | ||
- Add support for Permissioned DEX ([#2152](https://github.com/XRPLF/clio/pull/2152)) by [@mathbunnyru](https://github.com/mathbunnyru) | ||
- Switch Clio to use Conan v2 ([#2179](https://github.com/XRPLF/clio/pull/2179)) by [@mathbunnyru](https://github.com/mathbunnyru) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvements to the build system like this also seem like they should be categorized elsewhere too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good. Just some style and tense changes to match release notes.
chore: Commits for 2.5.0 (#2268) | ||
``` | ||
|
||
### What's Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### What's Changed | |
## What's Changed |
|
||
See the [Full Changelog on GitHub](https://github.com/XRPLF/clio/compare/2.4.1...2.5.0). | ||
|
||
### Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more grammatically appropriate for features to read in present simple tense:
"Adds xyz" instead of "Add xyz". "Implements" vs "implement" etc.
- Add support for Single Asset Vault ([#1979](https://github.com/XRPLF/clio/pull/1979)) by [@PeterChen13579](https://github.com/PeterChen13579) | ||
- Switch to xrpl/2.5.0 release ([#2267](https://github.com/XRPLF/clio/pull/2267)) by [@mathbunnyru](https://github.com/mathbunnyru) | ||
|
||
### Bug Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always seen bug fixes written in past tense. I'd probably apply past tense to all sections below, too.
|
||
### Features | ||
|
||
- Add extensions for ETLng ([#1967](https://github.com/XRPLF/clio/pull/1967)) by [@godexsoft](https://github.com/godexsoft) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, I don't think it's necessary to list the contributors here. There's the general list at the bottom, and listing the contributor in each line adds more noise to an already dense list.
DO NOT MERGE - looks like Clio 2.5.0 has failed on Mainnet, so this should be on hold.