-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Javascript: Batch transactions tutorial #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2e9d97c to
44b5541
Compare
44b5541 to
31e0479
Compare
f5667da to
4a08ad0
Compare
4a08ad0 to
d2cf306
Compare
|
FYI, updated to use this approach to check inner transactions:
|
db55a68 to
07b6d4f
Compare
07b6d4f to
7f16532
Compare
oeggert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, just a few suggestions to code. Also are we writing Batch transactions as Batch transactions? I think we should be wrapping it when we're referring to the specific transaction by name, but I don't think we've been very consistent in our docs.
@oeggert yes, good point we should be wrapping Batch when we refer to the transaction. I'll update. |
oeggert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #3366
temARRAY_EMPTY errorCurrently only Javascript-aware, but will add Python examples in a separate PR.
Preview here: https://xrpl-dev-portal--batch-transactions-tutorial.preview.redocly.app/docs/tutorials/how-tos/use-batch-transactions