Add code sample showing how to walk an owner directory #3381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mDuo13
added
python
pdp2121
reviewed
Nov 26, 2025
| const client = new xrpl.Client('wss://s.altnet.rippletest.net:51233') | ||
| await client.connect() | ||
|
|
||
| const owner = "rPT1Sjq2YGrBMTttX4GZHjKu9dyfzbpAYe" // Testnet faucet |
Contributor
There was a problem hiding this comment.
constant should be upper case, same with 2 constants below
pdp2121
reviewed
Nov 26, 2025
| console.log("Page #\t\t\tEntry count") | ||
| console.log("-----------------------------------") | ||
| while (true) { | ||
| // console.log(`Getting directory page ${sub_index}`) |
Contributor
There was a problem hiding this comment.
I would prefer we keeping the logs (instead of commenting out), so that users are aware of what's going on. Also, for log before an async call, probably consider adding ... so users know to wait for the call to finish
| ledger_index = resp.result.ledger_index | ||
| } | ||
|
|
||
| console.log(`${sub_index}\t\t\t${resp.result.node.Indexes.length}`) |
There was a problem hiding this comment.
nit: I'd prefer this have a sentence format for clarity or a descriptor of some kind, similar to the commented out log below
|
|
||
| # The entries are stored in the 'Indexes' field of the 'DirectoryNode' | ||
| entry_count = len(response.result["node"]["Indexes"]) | ||
| print(f"{sub_index}\t\t\t{entry_count}") |
achowdhry-ripple
approved these changes
Nov 26, 2025
achowdhry-ripple
left a comment
achowdhry-ripple
left a comment
There was a problem hiding this comment.
aside from a few nits looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the most useful code sample but it does provide a useful sample of using the
ledger_entrycommand to iterate over an account's owner directory and can be used to show owner directory fragmentation where it occurs.