Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary codec support for MPT amounts and STHash192 #556

Merged
merged 21 commits into from
Mar 29, 2025
Merged

Conversation

nkramer44
Copy link
Collaborator

Part one of MPT support.

Adds support for MPT amounts in AmountType, as well as support for STHash192

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 97.03947% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (10a6e2a) to head (79a9729).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a/org/xrpl/xrpl4j/model/transactions/Wrappers.java 66.66% 3 Missing ⚠️
...org/xrpl/xrpl4j/codec/binary/types/AmountType.java 95.74% 0 Missing and 2 partials ⚠️
...xrpl/xrpl4j/codec/binary/types/SerializedType.java 66.66% 2 Missing ⚠️
...xrpl4j/model/flags/MpTokenIssuanceCreateFlags.java 97.43% 0 Missing and 1 partial ⚠️
...xrpl/xrpl4j/model/transactions/CurrencyAmount.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #556      +/-   ##
============================================
+ Coverage     92.02%   92.26%   +0.23%     
- Complexity     1849     1968     +119     
============================================
  Files           383      408      +25     
  Lines          5128     5401     +273     
  Branches        436      459      +23     
============================================
+ Hits           4719     4983     +264     
- Misses          273      279       +6     
- Partials        136      139       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@sappenin sappenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nkramer44 and others added 3 commits March 27, 2025 16:42
@sappenin sappenin merged commit 3153d8d into main Mar 29, 2025
19 checks passed
@sappenin sappenin deleted the mpt-amounts branch March 29, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants