Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Escrow ITs #605

Closed
wants to merge 7 commits into from
Closed

Add additional Escrow ITs #605

wants to merge 7 commits into from

Conversation

sappenin
Copy link
Collaborator

@sappenin sappenin commented Mar 6, 2025

  • Add Finish + Cancel ITs for when the sender and receiver are the same.
  • Add IT for EscrowCreate with insufficient funds.
  • Fix logging logic in AbstractIT to properly display network explorer URLs.

@sappenin sappenin self-assigned this Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (85a1156) to head (94ef038).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #605   +/-   ##
=========================================
  Coverage     92.02%   92.02%           
  Complexity     1849     1849           
=========================================
  Files           383      383           
  Lines          5128     5128           
  Branches        436      436           
=========================================
  Hits           4719     4719           
  Misses          273      273           
  Partials        136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sappenin sappenin closed this Mar 6, 2025
@sappenin sappenin deleted the df/circular-escrow-it branch March 6, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant