feat(sdk): add integration tests and standardize ApiError handling#267
Merged
Xhristin3 merged 1 commit intoJun 16, 2026
Merged
Conversation
Xhristin3
approved these changes
Jun 16, 2026
Xhristin3
left a comment
Contributor
There was a problem hiding this comment.
Great work @Meet-hybrid! The response interceptor wrapping AxiosErrors into ApiError is exactly what the SDK needed — instanceof ApiError will make error handling much cleaner for consumers. The nock-based integration tests are comprehensive: auth flow (login, register, logout), stream operations with body verification, and a full 401 auto-refresh retry cycle. 26 tests all passing. Closes #224. 🚀
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the lack of automated verification for the SDK's actual HTTP communication. Previously, tests only
covered configuration resolution. This update introduces integration tests using nock and standardizes error handling
by ensuring all failed requests throw the SDK-native ApiError instead of raw AxiosError.
Changes
ApiError.
Impact
ApiError to catch and handle API-specific failures.
Verification Results
Ran npm test in the xstreamroll-sdk directory:
1 PASS tests/client.integration.test.ts
2 PASS tests/http.test.ts
3 PASS tests/client.test.ts
4 PASS tests/retry.test.ts
Fixes
Closes #224