Implement logout endpoint on API#285
Merged
Merged
Conversation
Xhristin3
approved these changes
Jun 17, 2026
Xhristin3
left a comment
Contributor
There was a problem hiding this comment.
Token denylist tied to remaining TTL + guard check on every request is the right shape. Replacing the placeholder X-User-Id header with real JWT validation is a great cleanup too. Tests look good. Merging 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR has fullfilled all the requirements needed
Provide a short description of the changes in this PR and the motivation/why.
Related issues
Link any related issues. Use
Closes #<id>to close issues automatically.Closes: #198
Type of change
Match the PR title to Conventional Commits:
<type>(<scope>): <summary>.Testing performed
Describe how you tested this change. Include commands, environment, and any setup steps.
Example:
Screenshots (if applicable)
Attach screenshots or animated GIFs for UI changes.
Checklist — author
origin/mainand resolved conflicts.npm run lint,npm run build,npm test.Checklist — reviewer guidance
Follow the full PR process in CONTRIBUTING.md — particularly: sync with
main, run quality gates, request a CODEOWNER review, and use squash-and-merge with a Conventional Commit-style squash message.