Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HDL DUC example #67

Open
wants to merge 8 commits into
base: 2024.2
Choose a base branch
from
Open

Conversation

robgraessle
Copy link
Collaborator

No description provided.

@robgraessle robgraessle requested a review from abehbood January 27, 2025 20:18
* 4 stages of FIR filter, with interpolation ratio of 2 in each stage and the overall interpolation ratio of 16.
* The first stage is a 64 tap square raised root cosine (SRRC) filter, and the next three stage filters are half-band (HB) interpolate by 2 FIR filter.
* 4 stages of FIR filter, with interpolation ratio of 2 in each stage and an overall interpolation ratio of 16.
* The first stage is a 64 tap square raised root cosine (SRRC) filter, and the next three stage filters are half-band (HB) interpolate-by-2 FIR filters.

## Example Model

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should say, one using kernels with buffer interfaces and the other using kernels with stream interfaces.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latency section, it says "The latency of the AI Engine design can be viewed in the Vitis Analyzer." I think this should be Model Composer and not Vitis Analyzer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the information in the Resource utilization section pretty light weight.

We should briefly say how to open the Vitis Analyzer from the Hub block.

We touch on kernels runtime ratios and suggest that the design is not ideal. But I am not sure why we stop there instead of changing runtime ratios and showing how we can optimize the design. Any opportunity to show how to optimize designs is useful to the end user. This is example presents a great opportunity.

This section should be redone to be a lot more informative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants