CR-1227316 : Fix bug in calling native C xrt::kernel API #8726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbramand <[email protected]>
rbramand-xilinx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When xrt::kernel is created using native C API XRT is throwing exception because of wrong constructor being called.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
PR - #8581 introduced the bug.
Discovered in regressions run on XOAH where application using native C API is run
How problem was solved, alternative solutions (if any) and why they were rejected
Passing empty xrt::module so that proper kernel impl constructor is called which fixes the issue.
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested the failing case added in CR and it passes after this fix
Documentation impact (if any)
NA