Update ROM VBNV name by reading shell version from AWS interface #8728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
The version strings for AWS are currently static.
AWS request is to show the rom vbnv name with version loaded that can change in future for F2 instance.
Added code to query the aws shell version from aws api and update rom vbnv name accordingly.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
The version strings for AWS are currently static.
AWS request is to show the rom vbnv name with version loaded that can change in future for F2 instance.
Added code to query the aws shell version from aws api and update rom vbnv name accordingly.
How problem was solved, alternative solutions (if any) and why they were rejected
Added code to query the aws shell version from aws api and update rom vbnv name accordingly.
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Verified the shell version from aws api is included as part of vbnv name.
Documentation impact (if any)
None