Create XRT Windows SDK when base-dev component is built #8733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSIS packager does not allow '-' in component name. Signed-off-by: Soren Soe <[email protected]>
Signed-off-by: Soren Soe <[email protected]>
When building the base-dev component on windows, support creating an SDK installer with the content of the development package. A new build option `build22.bat -sdk` enables building of the SDK, but requires NSIS to be installed on the build host. The `-sdk` build switch implies building for npu, which in turn builds both the base and npu components of XRT. In order to prevent build failures for folks who have not installed NSIS, the sdk is only built when explicitly requested through `-sdk`. ``` build22.bat -npu build22.bat -sdk build22.bat -npu -sdk ``` Signed-off-by: Soren Soe <[email protected]>
Signed-off-by: Soren Soe <[email protected]>
Signed-off-by: Soren Soe <[email protected]>
The capture library is a runtime plugin, do not release library or namelink component. Signed-off-by: Soren Soe <[email protected]>
This commit restores the default zip file generation for legacy XRT builds. For NPU builds it adds a zip file for the SDK as well the NSIS installer Signed-off-by: Soren Soe <[email protected]>
CPackDeb.cmake does not support -l{dir} which is required
when packaging plugin library libxrt_capture.so
Signed-off-by: Soren Soe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When building the base-dev component on windows, support creating
an SDK installer with the content of the development package.
How problem was solved, alternative solutions (if any) and why they were rejected
A new build option
build22.bat -sdkenables building of the SDK,but requires NSIS to be installed on the build host.
The
-sdkbuild switch implies building for npu, whichin turn builds both the base and npu components of XRT. In order to
prevent build failures for folks who have not installed NSIS, the sdk
is only built when explicitly requested through
-sdk.