Fix for CR-1224994 and CR-1226988 #8746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bisingha <[email protected]>
bisingha-xilinx
requested review from
chvamshi-xilinx and
mamin506
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Kernel Crash reported in https://jira.xilinx.com/browse/CR-1224994 and hang with trace enabled reported in https://jira.xilinx.com/browse/CR-1226988
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
#8669 The bug was calculating the size for the axlf buffer in ZOCL. The ZOCL used to calculate the size for axlf with (header_size * number_of_sections). And the number of sections we used to calculate (total_sections_in_xclbin-1). And after supporting flexible arrays this calculation was not valid. And the size of the axlf buffer was coming incorrect and ZOCL was failing to copy the whole axlf buffer from the userspace. And due to this the issues we saw reported on the mentioned CRs.
How problem was solved, alternative solutions (if any) and why they were rejected
Problem was solved by correcting the logic to calculate the size for the axlf buffer in ZOCL.
Risks (if any) associated the changes in the commit
n/a
What has been tested and how, request additional testing if necessary
Tested on multikernel_sharedmem_access testcase based on VCK190 BASE and k2kstrm_II_mismatch_fifo test based on VCK190 DFX
Documentation impact (if any)
n/a