Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-1228185, CR-1228210 and CR-1228177 #8747

Merged
merged 2 commits into from
Feb 6, 2025
Merged

CR-1228185, CR-1228210 and CR-1228177 #8747

merged 2 commits into from
Feb 6, 2025

Conversation

AShivangi
Copy link
Collaborator

Problem solved by the commit

  • CR-1228185 stoi() error when invalid argument supplied to xrt-smi examine -d
  • CR-1228210 xrt-smi validate -r accept upper case but seems xrt-smi examine -r does not
  • CR-1228177 Error Message Lacking --force

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

DSV bash testing

How problem was solved, alternative solutions (if any) and why they were rejected

  • added try/catch to handle stoi error
  • added boost::lower_to_copy to mimic examine behavior
  • Updated message

Risks (if any) associated the changes in the commit

N/A

What has been tested and how, request additional testing if necessary

tested on linux

Documentation impact (if any)

N/A

Signed-off-by: AShivangi <[email protected]>
@AShivangi AShivangi requested review from aktondak and removed request for rozumx and chvamshi-xilinx February 5, 2025 20:09
Signed-off-by: AShivangi <[email protected]>
@stsoe stsoe merged commit a1e39e6 into Xilinx:master Feb 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants