Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (optim/cailey_sgd): fix cailey sgd in float16/bfloat16 #1193

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

pablomlago
Copy link
Collaborator

Reason for this PR

Changes Made in this PR

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@pablomlago pablomlago changed the title Fix (optim/cailey_sgd): ensure that momentum buffer is in the same device/dtype as params Fix (optim/cailey_sgd): ensure that momentum buffer is in the same device/dtype as params and do qr_retraction in float32 Feb 14, 2025
@Giuseppe5
Copy link
Collaborator

More concise titles please :)

@pablomlago pablomlago changed the title Fix (optim/cailey_sgd): ensure that momentum buffer is in the same device/dtype as params and do qr_retraction in float32 Fix (optim/cailey_sgd): fix cailey sgd in float16/bfloat16 Feb 18, 2025
@Giuseppe5 Giuseppe5 merged commit 9cf2f97 into Xilinx:dev Feb 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants