Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replace distutil copy_tree with shutil #1268

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix: Replace distutil copy_tree with shutil #1268

merged 2 commits into from
Feb 7, 2025

Conversation

fpjentzsch
Copy link
Collaborator

Replace distutil copy_tree with shutil copytree for two reasons:

  1. It is deprecated
  2. I ran into this obscure bug, which does not happen with copytree: https://bugs.python.org/issue22132

@fpjentzsch fpjentzsch mentioned this pull request Jan 28, 2025
Merged
@auphelia auphelia self-requested a review February 7, 2025 16:36
auphelia
auphelia approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@auphelia auphelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fpjentzsch , I've also replaced the occurrences in the notebooks. Not sure if needed, but you might want to pull that into the finn-plus dev branch as well.

@auphelia auphelia merged commit 1cb5877 into Xilinx:dev Feb 7, 2025
2 checks passed
@fpjentzsch fpjentzsch deleted the fix/copytree branch March 4, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auphelia auphelia auphelia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpjentzsch @auphelia