Add C++ driver support #989
Merged
+562
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The C++ driver depends on #1210, so that I do not have to duplicate some of the builder options. In the meantime, there are still some details that I will polish up a bit for nicer integration. I have now moved both drivers into a single step called step_make_driver. If |
…n/finn into feature/integrateCppDriver
preusser
approved these changes
Apr 15, 2025
fpjentzsch
added a commit
to eki-project/finn-plus
that referenced
this pull request
May 10, 2025
* See also Xilinx#989 --------- Co-authored-by: Felix Jentzsch <[email protected]> Co-authored-by: bwintermann <[email protected]> Co-authored-by: auphelia <[email protected]>
auphelia
approved these changes
May 26, 2025
There was a problem hiding this comment.
Thank you, @LinusJungemann! Looks good to me as well :) I've added some small changes on code organization, tests and added the --force flag to the xclbinutil command to make it easier to re-run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the C++ driver for FINN https://github.com/eki-project/finn-cpp-driver
The C++ driver itself is added as a submodule to FINN.
Current v1.0 driver release note: https://github.com/eki-project/finn-cpp-driver/releases/tag/v1.0