Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix G_BUILD_VECTOR legalization #252

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix G_BUILD_VECTOR legalization #252

merged 1 commit into from
Jan 8, 2025

Conversation

abhinay-anubola
Copy link
Collaborator

Fixed incorrect destination register while legalizing G_BUILD_VECTOR

konstantinschwarz
konstantinschwarz previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@konstantinschwarz konstantinschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Would be nice to apply Andreu's suggestion before merging.

@abhinay-anubola abhinay-anubola force-pushed the sanubola.fix.legalize.build.vector branch from 0c78e42 to 92c870a Compare January 8, 2025 08:58
gbossu
gbossu reviewed Jan 8, 2025
View reviewed changes
llvm/test/CodeGen/AIE/aie2/intrinsics-shufflevec.ll
; CHECK-NEXT: vpush.hi.32 x2, x2, r0 // Delay Slot 4
; CHECK-NEXT: vpush.hi.32 x2, x2, r0 // Delay Slot 3
; CHECK-NEXT: vsel.32 x0, x2, x0, r16 // Delay Slot 2
; CHECK-NEXT: mov r16, r9 // Delay Slot 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we/I miss this 🙈

gbossu
gbossu reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@gbossu gbossu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't dare approve this change again 😆

@abhinay-anubola abhinay-anubola merged commit 7909ccf into aie-public Jan 8, 2025
8 checks passed
@abhinay-anubola abhinay-anubola deleted the sanubola.fix.legalize.build.vector branch January 8, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andcarminati andcarminati andcarminati left review comments

@gbossu gbossu gbossu left review comments

@konstantinschwarz konstantinschwarz konstantinschwarz approved these changes

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@khallouh khallouh Awaiting requested review from khallouh khallouh is a code owner

@martien-de-jong martien-de-jong Awaiting requested review from martien-de-jong martien-de-jong is a code owner

@SagarMaheshwari99 SagarMaheshwari99 Awaiting requested review from SagarMaheshwari99 SagarMaheshwari99 is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhinay-anubola @andcarminati @gbossu @konstantinschwarz