[AIE2P] Update AIE2PGenInstrInfo.td
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mludevid
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
khallouh
reviewed
Jan 15, 2025
| # TODO: llc %llcflags --filetype=asm -o %t2 | ||
| # TODO: llvm-mc -triple aie2p -filetype=obj -o %t %t2 | ||
| # TODO: llvm-objdump --triple=aie2p -dr --no-print-imm-hex %t | FileCheck %s | ||
| # Change TODOs to RUN once tied registers are implemented for POP and FILL instructions |
There was a problem hiding this comment.
As discussed offline, these encoding tests don't pass because we are missing some AsmParser support not because of the tied register implementation from @andcarminati. So I would keep them split as before so that we still have regression tests for the instruction that are actually supported.
There was a problem hiding this comment.
Done. I split up the tests again, kept the RUN lines in the vlda and vldb test files and removed the comment.
mludevid
force-pushed
the
mludevid.update.generated.files
branch
from
c38e8fa to
6afb6d9
Compare
khallouh
approved these changes
Jan 16, 2025
andcarminati
force-pushed
the
mludevid.update.generated.files
branch
from
6afb6d9 to
ea62057
Compare
mludevid
force-pushed
the
mludevid.update.generated.files
branch
from
ea62057 to
8fdba53
Compare
This was referenced Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the instruction definition of all instructions that use the loading fifo register. I also updated the respective decoder methods, the itinerary definitions, the binary output tests and any other test using these instructions. I had to disable some run lines in the binary output tests, because the assembly parser isn't working yet. We should be able to reenable them once @andcarminati merges the new subregister definitions for all of these instructions. For now I commented the old subregister definitions out, since we cannot define the new ones until the data structure changes to subregisters get merged.
I also used the opportunity to remove some old redundant test files.