-
Notifications
You must be signed in to change notification settings - Fork 25
[AIEX] Iterative feedback-driven post-pipeliner #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d90fec7
0eb7770
d8c1dc7
4eb9d7d
21753fa
3750708
bafc7be
fea2cc9
d10386e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,9 @@ class AIE2Subtarget : public AIE2GenSubtargetInfo, public AIEBaseSubtarget { | |
StringRef FS, StringRef ABIName, const TargetMachine &TM); | ||
|
||
bool enableMachineScheduler() const override { return true; } | ||
bool enableMachinePipeliner() const override { | ||
return AIEBaseSubtarget::enableMachinePipeliner(); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CHECK: we just disable the pre-pipeliner, not the prescheduler. And 'forcing' assumes infinite willingness on the part of the postpipeliner. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ... but the prescheduler follows the pre-pipeliner There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct, I'll add a small comment |
||
bool enablePostRAScheduler() const override { return true; } | ||
bool enablePostRAMachineScheduler() const override { return true; } | ||
bool forcePostRAScheduling() const override { return true; } | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1079,9 +1079,13 @@ MachineBasicBlock *AIEPreRASchedStrategy::nextBlock() { | |
// The prescheduler also clutters the view of the postpipeliner, so we skip | ||
// such blocks here. | ||
auto Skip = [](MachineBasicBlock *Block) { | ||
return PreSchedFollowsSkipPipeliner && Block && | ||
AIELoopUtils::isSingleMBBLoop(Block) && | ||
AIELoopUtils::getPipelinerDisabled(*Block); | ||
if (!Block) | ||
return false; | ||
bool PrePipelinerDisabled = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: |
||
AIELoopUtils::getPipelinerDisabled(*Block) || | ||
!Block->getParent()->getSubtarget().enableMachinePipeliner(); | ||
return PreSchedFollowsSkipPipeliner && | ||
AIELoopUtils::isSingleMBBLoop(Block) && PrePipelinerDisabled; | ||
}; | ||
|
||
do { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep just the base implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately
AIEBaseSubTarget
isn't actually a base class ofAIE2Subtarget