[AIE2P] Legalize and select VMUL.f from G_FMUL #360
+221
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khallouh
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
| MachineRegisterInfo &MRI = *MIRBuilder.getMRI(); | ||
|
|
||
| const Register DstReg = MI.getOperand(0).getReg(); | ||
| Register SrcLHS = MI.getOperand(1).getReg(); |
There was a problem hiding this comment.
nit: const for both.
khallouh
commented
Feb 19, 2025
| ; CHECK-NEXT: [[CONCAT_VECTORS:%[0-9]+]]:_(<64 x s32>) = G_CONCAT_VECTORS [[BITCAST]](<32 x s32>), [[DEF1]](<32 x s32>) | ||
| ; CHECK-NEXT: [[BITCAST1:%[0-9]+]]:_(<32 x s32>) = G_BITCAST [[AIE_INSERT_VECTOR_ELT1]](<64 x s16>) | ||
| ; CHECK-NEXT: [[CONCAT_VECTORS1:%[0-9]+]]:_(<64 x s32>) = G_CONCAT_VECTORS [[BITCAST1]](<32 x s32>), [[DEF1]](<32 x s32>) | ||
| ; CHECK-NEXT: [[FMUL:%[0-9]+]]:_(<64 x s32>) = G_FMUL [[CONCAT_VECTORS]], [[CONCAT_VECTORS1]] |
There was a problem hiding this comment.
We also have vmul.f that operates on X registers, I will change to legalize and select that one instead for less register pressure.
khallouh
force-pushed
the
hamza.fmul
branch
2 times, most recently
from
02cc673 to
872e379
Compare
khallouh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.