[AIE2p] Register re-allocation for BFP16 regs #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbossu
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
F-Stuckmann
reviewed
Feb 18, 2025
| @@ -591,6 +591,11 @@ bool AIE2PRegisterInfo::isVecOrAccRegClass( | |||
| if (AIE2P::ACC2048RegClass.hasSubClassEq(&RC)) | |||
| return true; | |||
|
|
|||
| // BFP16 registers | |||
| if (AIE2P::VEC576RegClass.hasSubClassEq(&RC) || | |||
| AIE2P::eEYRegClass.hasSubClassEq(&RC)) | |||
There was a problem hiding this comment.
nice, we're also checking the "double registers"
There was a problem hiding this comment.
Nit: define a new register class VEC1152 with eEY and use it here?
F-Stuckmann
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable register re-allocation for EX/EY registers. Needed for Conv2D_bfp16