[AIEX] Add address chaining for fixed stack objects #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andcarminati
requested review from
abhinay-anubola,
abnikant,
F-Stuckmann,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
andcarminati
commented
Oct 1, 2025
| ; CHECK-NEXT: nop | ||
| ; CHECK-NEXT: nop | ||
| ; CHECK-NEXT: nop | ||
| ; CHECK-NEXT: mov p0, sp |
There was a problem hiding this comment.
Interesting case, I will take a look!
There was a problem hiding this comment.
I looks like we combine frame index + load store to _spill variants. I tried to prevent this case, but it also prevents some good opportunities.
andcarminati
force-pushed
the
andreu.stack.chain
branch
from
3d573aa to
8b2d38e
Compare
F-Stuckmann
reviewed
Oct 6, 2025
| if (!MFI.isFixedObjectIndex(FrameIdx)) | ||
| continue; | ||
|
|
||
| if (IsUsedByLoad(FIInstr)) |
There was a problem hiding this comment.
should we worry about stores?
There was a problem hiding this comment.
why do we differentiate between loads and non-loads? shouldn't it only be related to the FrameIdx?
There was a problem hiding this comment.
Maybe we could vanish this, because we break the chain using hasMixedLoadStoreUse. I will check this.
andcarminati
force-pushed
the
andreu.stack.chain
branch
from
8b2d38e to
a6b6eb4
Compare
F-Stuckmann
reviewed
Oct 7, 2025
| } | ||
|
|
||
| bool Changed = false; | ||
| auto ReplaceFI = [&](std::vector<MachineInstr *> &FIs) { |
There was a problem hiding this comment.
nit: with the simplification, do we need the lambda here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.