[AIE2P] split offsets before postincrment in large Load/Stores #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-Stuckmann
requested review from
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
andcarminati
reviewed
Oct 7, 2025
| case AIE2P::G_AIE_POSTINC_3D_STORE: { | ||
| for (unsigned SubRegIdx = 0; SubRegIdx < SplitFactor; ++SubRegIdx) { | ||
| for (unsigned Part = 0; Part < SplitFactor; ++Part) { | ||
| const unsigned SubRegIdx = AMI.MemI.getOpcode() == AIE2P::G_STORE |
There was a problem hiding this comment.
Why do we need to handle differently S_STORE? They will expand to offset stores anyway... If we have a strong objection we could also have a comment.
There was a problem hiding this comment.
good catch, we can simplify it
andcarminati
reviewed
Oct 7, 2025
| case AIE2P::G_AIE_POSTINC_2D_LOAD: | ||
| case AIE2P::G_AIE_POSTINC_3D_LOAD: { | ||
| for (unsigned SubRegIdx = 0; SubRegIdx < SplitFactor; ++SubRegIdx) { | ||
| for (unsigned Part = 0; Part < SplitFactor; ++Part) { |
There was a problem hiding this comment.
Same comment as the G_STORE one.
F-Stuckmann
force-pushed
the
stuckmann.split.large.ls
branch
from
3d93257 to
d2025b0
Compare
|
Do you think we could have another QoR run because of the G_LOAD/G_STORE change? |
|
Before force pushing the change, I ran QoR to verify nothing degraded.
|
|
This looks good to me, I only recommend to fix the commit message before approval. |
Put the zero-offset part last, since it doesn't need the pointer to survive.
F-Stuckmann
force-pushed
the
stuckmann.split.large.ls
branch
from
d2025b0 to
1817126
Compare
|
I updated the commit message |
F-Stuckmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the zero-offset part last, since it doesn't need the pointer to survive.
Note: This is a preparation PR for GEMM.