[AIEX][NFC] Refactor Intrinsic Attributes #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e919ee.
F-Stuckmann
requested review from
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
|
Should this be NFC? |
andcarminati
reviewed
Oct 7, 2025
| //===----------------------------------------------------------------------===// | ||
| class AIE2EventIntrinsic | ||
| : Intrinsic<[], | ||
| : DefaultAttrsIntrinsic<[], |
F-Stuckmann
changed the title
F-Stuckmann
force-pushed
the
stuckmann.intrinsics
branch
from
0c0eddd to
10f0d1b
Compare
|
I updated the commit message to clarify that it is a NFC change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonize the Intrinsics attributes: Use
DefaultAttrsIntrinsicfor all AIE intrinsics.