[AIEX] Extend Staged 2D/3D regalloc to avoid spills #685
+1,279
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andcarminati
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto and
stephenneuendorffer
as code owners
|
QoR results: 
|
|
Thanks you @andcarminati, very much !! |
| addPass(createGreedyRegisterAllocator(onlyAllocate3D2DRegisters)); | ||
| addPass(createAIESuperRegRewriter()); | ||
| if (EnableFineGrainedStagedRA) | ||
| addPass(createAIEUnallocatedSuperRegRewriter()); |
There was a problem hiding this comment.
Check : I think we should try the following, it should be helpful for onlyAllocate3D2DRegisters pass
addPass(createGreedyRegisterAllocator(onlyAllocate3DRegisters));
addPass(createAIESuperRegRewriter());
if (EnableFineGrainedStagedRA)
addPass(createAIEUnallocatedSuperRegRewriter());
addPass(createGreedyRegisterAllocator(onlyAllocate3D2DRegisters));
addPass(createAIESuperRegRewriter());
if (EnableFineGrainedStagedRA)
addPass(createAIEUnallocatedSuperRegRewriter());
There was a problem hiding this comment.
I would like to keeps as simple as possible now to setup a common ground first, and then we can test small changes to see the impact. I think it will better to decide.
|
Also do you think following commit will help ? |
Now we filter by register class and usage. Basically, we exclude here instructions like copies and non-2D/3D ones. Co-Authored-By: Krishnam Tibrewala <[email protected]>
…gisters Co-Authored-By: Krishnam Tibrewala <[email protected]>
Maybe yes! As mentioned before, I prefer to keep just the minimal necessary changes. We can test after, on top of this PR. |
Co-Authored-By: Krishnam Tibrewala <[email protected]>
…reedy run Co-Authored-By: Krishnam Tibrewala <[email protected]>
If we don't need a full register, we can expand to individual lanes. Co-Authored-By: Krishnam Tibrewala <[email protected]>
Co-Authored-By: Krishnam Tibrewala <[email protected]>
Co-Authored-By: Krishnam Tibrewala <[email protected]>
This avoids cycles in bundles that appear in VirtRegRewriter. We also update LIs related to src and dst operands of those expanded copies. Co-Authored-By: Krishnam Tibrewala <[email protected]>
andcarminati
force-pushed
the
andreu.extend.2d3d.allocation
branch
from
31b7e71 to
a27561f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is intended to avoid 3D/3D (when possible) register spills.
The idea and rationale behind this work is in a previous Draft PR: #442.
To review, I recommend to follow this PR commit by commit.
Credits also for the co-author @krishnamtibrewala.