Skip to content

Commit

Permalink
[OpenMP] Fix comparison to True/False in openmp/**.py (llvm#94041)
Browse files Browse the repository at this point in the history
from PEP8
(https://peps.python.org/pep-0008/#programming-recommendations):

> Comparisons to singletons like None should always be done with is or
is not, never the equality operators.

Co-authored-by: Eisuke Kawashima <[email protected]>
  • Loading branch information
e-kwsm and e-kwsm authored Jul 16, 2024
1 parent 16dd75b commit 11a9ab1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion openmp/libompd/gdb-plugin/ompd/ompd.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def invoke(self, arg, from_tty):
"No ompd_dll_locations symbol in execution, make sure to have an OMPD enabled OpenMP runtime"
)

while gdb.parse_and_eval("(char**)ompd_dll_locations") == False:
while not gdb.parse_and_eval("(char**)ompd_dll_locations"):
gdb.execute("tbreak ompd_dll_locations_valid")
gdb.execute("continue")

Expand Down
2 changes: 1 addition & 1 deletion openmp/tools/archer/tests/lit.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ if config.operating_system == 'Darwin':
if 'Linux' in config.operating_system:
config.available_features.add("linux")

if config.has_tsan == True:
if config.has_tsan:
config.available_features.add("tsan")

# to run with icc INTEL_LICENSE_FILE must be set
Expand Down

0 comments on commit 11a9ab1

Please sign in to comment.