[FXML-4281] Remove flag for rounding mode of casting ops #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaAMD
approved these changes
Apr 19, 2024
mgehre-amd
approved these changes
Apr 22, 2024
mgehre-amd
reviewed
Apr 22, 2024
josel-amd
approved these changes
Apr 22, 2024
mgehre-amd
reviewed
Apr 22, 2024
mgehre-amd
approved these changes
Apr 22, 2024
cferry-AMD
force-pushed
the
corentin.remove_cast_flag
branch
from
b8f8efd to
10282d0
Compare
|
Reconciled this PR with what's been merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per upstream review, it appeared that the rounding mode does not affect casts but only function calls. Because we're only issuing casts in this pass, we can get rid of the
float-to-int-truncatesflag -- for casts, this is always true.