Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand-ops: minsi/maxsi (and unsigned) #171

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

mgehre-amd
Copy link
Collaborator

Since the last LLVM bump, arith gained new ops minsi, maxsi, minui and maxui, which are used by some tosa-to-linalg lowerings.
Expand them into cmp + select to be able to lower into emitc.

@mgehre-amd mgehre-amd requested review from cferry-AMD, josel-amd and TinaAMD and removed request for cferry-AMD April 29, 2024 11:58
Copy link
Collaborator

@cferry-AMD cferry-AMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

edit: Sorry, I didn't see I got dropped from the reviewers. You only get an email when you're added in!

Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgehre-amd mgehre-amd removed the request for review from josel-amd April 29, 2024 13:52
Base automatically changed from matthias.backport_emitc to feature/fused-ops April 29, 2024 13:55
@mgehre-amd mgehre-amd enabled auto-merge (squash) April 29, 2024 13:55
@mgehre-amd mgehre-amd merged commit ac54176 into feature/fused-ops Apr 29, 2024
3 checks passed
@mgehre-amd mgehre-amd deleted the matthias.maxsi_minsi branch April 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants