Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDLL native operator abs #173

Merged
merged 6 commits into from
May 3, 2024
Merged

PDLL native operator abs #173

merged 6 commits into from
May 3, 2024

Conversation

ge28boj
Copy link

@ge28boj ge28boj commented May 2, 2024 •
edited
Loading

PDLL native operator abs and some code refactor in Builtins.cpp and Builtins.h

ttjost
ttjost approved these changes May 3, 2024
View reviewed changes
Copy link

@ttjost ttjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but please check if we can make those changes.

@ge28boj ge28boj merged commit 746aa23 into feature/fused-ops May 3, 2024
3 checks passed
@ge28boj ge28boj deleted the liangta.abs branch May 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttjost ttjost ttjost approved these changes

@mgehre-amd mgehre-amd mgehre-amd approved these changes

@flemairen6 flemairen6 flemairen6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ge28boj @ttjost @mgehre-amd @flemairen6