[TOSA][Constant Fold] Support floating point for reduce_sum, reduce_prod, reduce_max, reduce_min #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
May 8, 2024
| @@ -49,8 +49,7 @@ OffsetType indexToOffset(DimensionType shape, DimensionType index) { | |||
| return offset; | |||
| } | |||
|
|
|||
| SmallVector<int64_t> offsetToIndex(DimensionType shape, | |||
There was a problem hiding this comment.
Can you please revert all reformatting changes from this file? Upstream typically doesn't accept them and it will make our fork diverge more from upstream, making upstreaming harder.
ge28boj
force-pushed
the
liangta.tosa_const_fold_reduce_sum_floating_point
branch
from
d8ae7eb to
63db985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close this PR, please see #181