Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FXML-4614] Use EmitC index types in all passes creating EmitC #186

Merged
merged 18 commits into from
May 21, 2024
Merged

[FXML-4614] Use EmitC index types in all passes creating EmitC #186

merged 18 commits into from
May 21, 2024

Conversation

cferry-AMD
Copy link
Collaborator

@cferry-AMD cferry-AMD commented May 16, 2024 •
edited
Loading

This PR:

  • brings in EmitC size_t, ssize_t to SCFToEmitC, FuncToEmitC, MemrefToEmitC
    • MemrefToEmitC: no structural changes needed (these were already op conversion patterns using type converters),
    • FuncToEmitC: perform type conversions then operation conversions, to enable use of existing interface type conversion patterns without conflicting with FuncToEmitC op conversion patterns.
    • SCFToEmitC: switch from op rewrite patterns to op conversion patterns.
  • introduces materializers for unrealized conversions (allowing xyzToEmitC passes to leave unrealized casts, solved later on by reconciling them with the dedicated pass)

Base automatically changed from corentin.emitc_integral_types to feature/fused-ops May 16, 2024 13:25
@cferry-AMD cferry-AMD force-pushed the corentin.emitc_use_types_in_other_passes branch from f941ccc to 0c47b6a Compare May 16, 2024 14:37
@cferry-AMD cferry-AMD marked this pull request as ready for review May 17, 2024 09:50
@cferry-AMD cferry-AMD requested review from mgehre-amd and TinaAMD May 17, 2024 09:50
@TinaAMD TinaAMD requested review from josel-amd and TinaAMD and removed request for TinaAMD May 17, 2024 14:22
TinaAMD
TinaAMD approved these changes May 17, 2024
View reviewed changes
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and handing over to @josel-amd since I am on vacation next week.

@mgehre-amd
Copy link
Collaborator

Looks great! Just waiting to see how the FuncToEmitC will play out

mgehre-amd
mgehre-amd approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

josel-amd
josel-amd approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@josel-amd josel-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cferry-AMD cferry-AMD merged commit 69cc7e1 into feature/fused-ops May 21, 2024
3 checks passed
@cferry-AMD cferry-AMD deleted the corentin.emitc_use_types_in_other_passes branch May 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgehre-amd mgehre-amd mgehre-amd approved these changes

@TinaAMD TinaAMD TinaAMD approved these changes

@josel-amd josel-amd josel-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cferry-AMD @mgehre-amd @TinaAMD @josel-amd