-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FXML-4614] Use EmitC index types in all passes creating EmitC #186
[FXML-4614] Use EmitC index types in all passes creating EmitC #186
Conversation
f941ccc
to
0c47b6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and handing over to @josel-amd since I am on vacation next week.
Looks great! Just waiting to see how the FuncToEmitC will play out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR:
size_t
,ssize_t
to SCFToEmitC, FuncToEmitC, MemrefToEmitC