Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: constant fold tosa.tile when input is splat. #187

Merged
merged 2 commits into from
May 17, 2024
+45 −1
Merged

feat: constant fold tosa.tile when input is splat. #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e20bf
feat: constant fold tosa.tile when input is splat.
ttjost May 16, 2024
98430c8
chore: update comment.
ttjost May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp
View file
Original file line number Diff line number Diff line change
@@ -1736,11 +1736,19 @@ DenseElementsAttr tile(DenseElementsAttr inputValues, ShapedType outputType) {
auto inputType = inputValues.getType();
auto baseType = inputType.getElementType();

if (inputValues.isSplat()) {
if (isa<IntegerType>(baseType))
return DenseElementsAttr::get(outputType,
inputValues.getSplatValue<APInt>());
return DenseElementsAttr::get(outputType,
inputValues.getSplatValue<APFloat>());
}

// Handle possible integer types
if (auto intType = dyn_cast<IntegerType>(baseType)) {
switch (intType.getWidth()) {
case 1:
// i1 has special alignment which is not handled by transposeTypeRaw.
// i1 has special alignment which is not handled by tileTypeRaw.
return tileType<bool>(inputValues, inputType, outputType);
case 8:
return tileTypeRaw<uint8_t>(inputValues, inputType, outputType);
36 changes: 36 additions & 0 deletions mlir/test/Dialect/Tosa/constant-tile.mlir
View file
Original file line number Diff line number Diff line change
@@ -106,4 +106,40 @@ func.func @tile_f16_many_dimensions() -> (tensor<6x2x2xf16>) {
%1 = tosa.tile %0 {multiples = array<i64: 3, 2, 1>} : (tensor<3x1x1xf16>) -> tensor<6x2x2xf16>
// NO-FOLDING-CHECK: tosa.tile
return %1 : tensor<6x2x2xf16>
}

// CHECK-LABEL: @tile_i1_splat
func.func @tile_i1_splat() -> (tensor<1x2x2x2xi1>) {
// CHECK: "tosa.const"() <{value = dense<false> : tensor<1x2x2x2xi1>}>
%0 = "tosa.const"() <{value = dense<false> : tensor<1x1x1x1xi1>}> : () -> tensor<1x1x1x1xi1>
%1 = tosa.tile %0 {multiples = array<i64: 1, 2, 2, 2>} : (tensor<1x1x1x1xi1>) -> tensor<1x2x2x2xi1>
// NO-FOLDING-CHECK: tosa.tile
return %1 : tensor<1x2x2x2xi1>
}

// CHECK-LABEL: @tile_i32_splat
func.func @tile_i32_splat() -> (tensor<1x2x2x2xi32>) {
// CHECK: "tosa.const"() <{value = dense<2> : tensor<1x2x2x2xi32>}>
%0 = "tosa.const"() <{value = dense<2> : tensor<1x1x1x1xi32>}> : () -> tensor<1x1x1x1xi32>
%1 = tosa.tile %0 {multiples = array<i64: 1, 2, 2, 2>} : (tensor<1x1x1x1xi32>) -> tensor<1x2x2x2xi32>
// NO-FOLDING-CHECK: tosa.tile
return %1 : tensor<1x2x2x2xi32>
}

// CHECK-LABEL: @tile_f16_splat
func.func @tile_f16_splat() -> (tensor<1x2x2x2xf16>) {
// CHECK: "tosa.const"() <{value = dense<1.000000e+00> : tensor<1x2x2x2xf16>}>
%0 = "tosa.const"() <{value = dense<1.000000e+00> : tensor<1x1x1x1xf16>}> : () -> tensor<1x1x1x1xf16>
%1 = tosa.tile %0 {multiples = array<i64: 1, 2, 2, 2>} : (tensor<1x1x1x1xf16>) -> tensor<1x2x2x2xf16>
// NO-FOLDING-CHECK: tosa.tile
return %1 : tensor<1x2x2x2xf16>
}

// CHECK-LABEL: @tile_bf16_splat
func.func @tile_bf16_splat() -> (tensor<1x2x2x2xbf16>) {
// CHECK: "tosa.const"() <{value = dense<1.000000e+00> : tensor<1x2x2x2xbf16>}>
%0 = "tosa.const"() <{value = dense<1.000000e+00> : tensor<1x1x1x1xbf16>}> : () -> tensor<1x1x1x1xbf16>
%1 = tosa.tile %0 {multiples = array<i64: 1, 2, 2, 2>} : (tensor<1x1x1x1xbf16>) -> tensor<1x2x2x2xbf16>
// NO-FOLDING-CHECK: tosa.tile
return %1 : tensor<1x2x2x2xbf16>
}