Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TosaCanonicalize): create FusedLoc when folding clamp #189

Merged

Conversation

cmcgirr-amd
Copy link

During Tosa Clamp folding the location information of one of the clamps was being lost due to the newly created operation simply taking only a single location rather than the fused location.

The following fix extends the replaceOpWithNewOp to allow the user to give a list of locations so that a FusedLoc can be created on the newly generated operation.

@cmcgirr-amd cmcgirr-amd requested review from ttjost and mgehre-amd May 21, 2024 09:57
Copy link

@ttjost ttjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a nice feature to be upstreamed as well. Thanks!

@ttjost ttjost merged commit 23bebca into feature/fused-ops May 21, 2024
4 checks passed
@ttjost ttjost deleted the christopher.fix_clamp_canonicalization_loc branch May 21, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants