Fix discrepancy in EmitC parser/printer #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
May 22, 2024
|
Changing the meaning of of current IR by changing the default type might be controversial. Fine for me, but something to explicitly mention when upstreaming. |
mgehre-amd
approved these changes
May 22, 2024
We can defer that change to the PR that drops index type support when upstreaming. Let's make a specific discussion on the Discord about that. |
Co-authored-by: Matthias Gehre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitc.size_tis the default type in emitc::ForLoop induction variables now, so the type is not printed in the MLIR "assembly". However, index type is still assumed at parse time barring further type information in the IR. This commit reconciles the print and parse behavior to assumeemitc.size_tas the default type.